Skip to content

updated django to 4.2.15 #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bwang-icf wants to merge 5 commits into from
Closed

updated django to 4.2.15 #1254

bwang-icf wants to merge 5 commits into from

Conversation

@bwang-icf
Copy link
Contributor

@bwang-icf bwang-icf commented Oct 11, 2024

JIRA Ticket:
BB2-3349

What Does This PR Do?

Upgrading Django to 4.2.15

What Should Reviewers Watch For?

Any breaking portions of the site

If you're reviewing this PR, please check for these things in particular:

Any breaking unit tests

Validation

Ran unit tests with success

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
    security engineer's approval.

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime,
      etc)
  • No migrations

JFU-NAVA-PBC
JFU-NAVA-PBC suggested changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@JFU-NAVA-PBC JFU-NAVA-PBC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exceptiongroup not needed for python 3.11, it is pulled in due to pip-compile running on python 3.9, recommend run pip-compile on python 3.11

image

JFU-NAVA-PBC
JFU-NAVA-PBC reviewed Oct 11, 2024
View reviewed changes
Copy link
Contributor

@JFU-NAVA-PBC JFU-NAVA-PBC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not see change in requirements.in - the input for pip-compile?

look forward to more commits coming in...

@JFU-NAVA-PBC JFU-NAVA-PBC self-requested a review October 23, 2024 21:20
@JFU-NAVA-PBC
Copy link
Contributor

JFU-NAVA-PBC commented Oct 23, 2024

also run : make reqs-download

it will downloads the tars / wheels into vendor directory, which the deploy task will be installing dependencies from...

since the re-generated requirements.dev.txt replaced some dependencies, need to git remove the old file and git add the new file... etc.

reqs-download:
pip download -r requirements/requirements.dev.txt --dest vendor --platform manylinux2014_x86_64 --abi cp311 --no-deps

JFU-NAVA-PBC
JFU-NAVA-PBC reviewed Oct 23, 2024
View reviewed changes
Copy link
Contributor

@JFU-NAVA-PBC JFU-NAVA-PBC left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Django 4.2.11 wheel file is still around - should be removed when django bumpped to 4.2.14, now we are at 4.2.15, so remove both Django 4.2.11 and 4.2.15 when bumpped to 4.2.15.

image

Also check other dependencies to removed older version binary if a newer version binary was introduced due to django bump.

@bwang-icf bwang-icf closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JFU-NAVA-PBC JFU-NAVA-PBC JFU-NAVA-PBC requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JFU-NAVA-PBC JFU-NAVA-PBC

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bwang-icf @JFU-NAVA-PBC